Added version to ExecutionEnv proto message #5506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5506 +/- ##
==========================================
- Coverage 61.01% 60.99% -0.02%
==========================================
Files 794 794
Lines 51441 51443 +2
==========================================
- Hits 31385 31380 -5
- Misses 17164 17171 +7
Partials 2892 2892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrewwdye
previously approved these changes
Jun 24, 2024
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
pingsutw
approved these changes
Jun 24, 2024
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
* added version to ExecutionEnv proto message Signed-off-by: Daniel Rammer <[email protected]> * spelling fix Signed-off-by: Daniel Rammer <[email protected]> * improving version docs Signed-off-by: Daniel Rammer <[email protected]> * spelling is hard Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
* added version to ExecutionEnv proto message Signed-off-by: Daniel Rammer <[email protected]> * spelling fix Signed-off-by: Daniel Rammer <[email protected]> * improving version docs Signed-off-by: Daniel Rammer <[email protected]> * spelling is hard Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
A simple ID is not enough to uniquely identify a ExecutionEnv.
What changes were proposed in this pull request?
Adding a version to the ExecutionEnv.
How was this patch tested?
Locally.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA